Brandon Payton

Results 281 comments of Brandon Payton

Unfortunately, reproducing the segfault appears to require building nginx with a module that sets request_body to NULL and triggering it, but perhaps it would be sufficient to observe that making...

> On another note, I just realized that [nginx checks r->request_body->bufs for NULL](https://github.com/nginx/nginx/blob/828fb94e1dbe1c433edd39147ba085c4622c99ed/src/http/ngx_http_variables.c#L2060) when checking request_body, so I plan to add that the same sort of check to this PR...

Unfortunately, due to an oversight, `_renderUrl` is not currently called in `Request`. This issue and #68 started me thinking about a more general solution for these sorts of feature requests....

One note: I don't love the name `renderFetchQueryParams`, but it seemed too generic to name a fetch-specific thing `renderQueryParams`.

@neonstalwart and @kfranqueiro, thanks for the feedback. Here's a wall of text for the holidays. :) We seem to be on the same page about not introducing needless abstractions, but...

Hi @neonstalwart, > @brandonpayton i wanted to respond directly to some of your comments but my responses are kind of terse and scattered which may make them seem hostile -...

@neonstalwart, I wanted to keep things simple and direct, but my response probably could have used the same warning about terseness.

I can confirm that `aria-labelledby` causes the column name to be read along with the content by JAWS 15 / Chrome and the OSX ML screen reader w/ Chrome.

I apologize; I should have been clearer. When working with other grids with very similar DOM structure, I have seen screen readers respond to `aria-labelledby` by reading the column header...

Hi @mercmobily, I think we ended up talking about two different things: 1. Whether this set of stores would be useful to incorporate in the dstore test set 2. Whether...