Frederic Branczyk comments

Results 513 comments of


                                            Frederic Branczyk

Add Summary metrics

I think extensibility would be a good compromise.

Allow limiting grpc codes tracked in histrogram

2) would be totally possible as a major version breaking change, so that sounds good to me. What's left to "finalize"? Happy to help out!

Document how to register Server or change init() to register the same way

I think we should generally recommend not to use the globals/init, so the latter sounds good to me.

Option to reduce cardinality of grpc_server_handled_total

Are you asking for lazy initialization or the ability to add/remove labels?

Option to reduce cardinality of grpc_server_handled_total

Got it. I think that request is reasonable, however, keep in mind that we are in the process of reworking this project (RE: https://github.com/grpc-ecosystem/go-grpc-prometheus/issues/91), and as a result we are...

pre-defining gRPC call metrics

Are you looking for [`.InitializeMetrics`](https://github.com/grpc-ecosystem/go-grpc-prometheus/blob/ae0d8660c5f2108ca70a3776dbe0fb53cf79f1da/server_metrics.go#L132)?

pre-defining gRPC call metrics

I don’t believe it exists, but I think I’d be a great addition! :)

do we have c++ client library as well?

I work only with go and this repo, I don't know more than what anyone could google, sorry :/ . Maybe @bwplotka knows about something?

Grafana dashboard for go-grpc-prometheus

Nice :slightly_smiling_face: ! Any chance you would like to convert this to a [Prometheus mixin](https://docs.google.com/document/d/1A9xvzwqnFVSOZ5fD3blKODXfsat5fg6ZhnKu9LK3lB4/edit#heading=h.gt9r2h2gklj3)? That would be super nice as it can be used more declaratively that way.

change injected PromQL label from labels.MatchEqual to labels. MatchRegexp to support multiple namespaces

If multiple values is the use case, I would prefer if we made the query parameter repeatable instead of using a regex. The regex is going to be difficult security...