Results 133 comments of Brian Kim

Not sure why the linting is failing btw Edit: oh nm it was prettier

Another data point from @ferm10n https://github.com/graphql/vscode-graphql/pull/335#issuecomment-964669387

@saihaj > Why not use the enum directly? I’m not sure I want to import a file from graphql-js just to access the enum value. And in the case of...

@IvanGoncharov It’s not a blocker! Thankfully with TypeScript there are workarounds. Just surfacing the struggle in case others having it. @benjie `keyof typeof` is a new one to me! That’s...

Another detail is that we’re using `typeof Enum` in various places (https://github.com/graphql/graphql-js/blob/main/src/language/directiveLocation.ts#L33), and it doesn’t actually seem to work as expected. ```ts enum Foo { a = 1, b =...

> This is why we introduced result.all, so that discreet changes could be asserted if required, but in general I advise folks to not be too concerned about the intermediate...

Ah, didn’t see that. So the loop runs at the speed of `act()`?

So, I’m too lazy to debug it right now, but does the `waitForNextUpdate()` function still rely on some kind of looping/polling mechanism, which fires the resolver function repeatedly? I’m still...

Hi, I’m in a similar situation. I’m prototyping a bundler and I keep running into issues using the WHATWG URL class, specifically because it does not parse origin-relative URLs. The...

@annevk I’m currently experimenting with using a custom protocol for the base (currently `local:///`) and it actually seems to be working out. It seems like it’s important to use 1...