Brad Rydzewski

Results 251 comments of Brad Rydzewski

the code in my comment is pseudo code, so please feel free to adjust the logic as needed. The request is to break out into a helper function to improve...

👋 Hey there, while I appreciate the pull request, I recommend reading this thread: https://discourse.drone.io/t/drone-netrc-username-documentation-usage/4485/2 The netrc file is considered _Internal use only_ and is subject to change. We are...

I think a more thorough design review is going to be required and I want to be up front that this will take some time. We will assign this to...

I am not sure about the security impact either, but that is something we should know before merging. This plugin receives special treatment by the Drone engine, and therefore deserves...

So if I understand this correctly, the goal would be for every plugin in the organization to have a `plugins.jsonnet` file that can be imported as a library. For example:...

my recommendation would be that someone add a unit test for the type of key they think is failing to parse and/or panic https://github.com/appleboy/drone-ssh/blob/master/plugin_test.go this should be easily provable

sounds like a good request. If someone can send a PR, we can take a look and merge quickly.

copying response from #3280 @sajithvasu the plan is to move all of our images to `scratch`. Drone is a statically compiled binary and does not require or use the container...

There are some pre-requisites for integrating a third party provider with Drone, which I discuss here: https://github.com/harness/gitness/issues/3251#issuecomment-1385606916 > The first step to supporting a new Git provider is to add...