Brad Rydzewski
Brad Rydzewski
`distroless` images contain runtime dependencies. Drone does not have any runtime dependencies, therefore,`scratch` is more appropriate.
thanks for submitting the pull request. I have added some comments about specific sections of code. I also recommend taking a look at AWS or GCP and trying to more...
thanks, could you please add a unit test that re-creates the state required to reproduce, and that fails without this fix, but passes with the fix? If you look at...
we would probably want to document the env file format in a separate, dedicated page, and then link to that page from the quick start. The env file is used...
@guessi thanks, can you please provide the link where you are sourcing the AMI list? For security purposes, we need to manually verify before we can merge (sorry, this is...
I noticed these images are being labeled as `hvm-ssd` but the autoscaler does not use ssd disk types by default. Have you tested any of these new amis with default...
I have no problem with ssd or even ssd by default, I just want to make sure that if someone runs the autoscaler with default options it will work out...
> you will find that current images are hvm-ssd already. thanks! I think this is the context I was missing
Instead of a helper function for parsing the build number perhaps instead providing a more descriptive, shared error message? ```diff + var errInvalidBuildNumber = errors.New("Missing or invalid build number") ***************...
I think `Missing or invalid build number` is descriptive enough. I'm not saying there is anything wrong with your code. It is just my personal preference to opt for a...