Brad Rydzewski
Brad Rydzewski
@tboerger it looks like the `go.mod` file uses `gopkg.in/h2non/gock.v1` as the module name so we may need to change the import. Very strange they are using gopkg with go.mod but...
I think I need some context with this issue. The original discourse thread was not very clear
ah ok, is this issue a suggestion to change the response code to 424 when the yaml does not exist? sorry, I did not understand at first.
The 'Not Found' error message is coming from GitHub, not from Drone. This is one of many error messages that could be returned from GitHub, so returning a 424 may...
I really dislike the way we parse webhooks today. I would like to add methods to more closely match the go-github library where parse and verify are separate methods, with...
> the library requires the user to always use the package I prefer that the user always invokes the normalizer package if needed. Most people will never need this package,...
> if we present this normalization as a utility function, that means the user must always opt-in Correct, we would require a user to always opt-in if they want to...
I have some reservations. The purpose of this repository is to abstract common functionality across all git providers (github, bitbucket, gitlab, etc). This adds github-only functionality to all providers. I...
@bhavya181 I understand this is pusedo code, however, I do not understand what this pull request is trying to achieve which makes it difficult to review. Going forward please include...
@TP I see where you are going with this, and it is a clever workaround. The only thing that gives me pause is these are two different endpoints with different...