Brad Fitzpatrick

Results 299 comments of Brad Fitzpatrick

That's fine. Not intentional or anything; this package is just super old & predates many modern conventions.

TestFormatVariant. I found this due to Google's internal testing infrastructure. We're using this patch internally to make tests happy. Verify with: $ go get -u github.com/godbus/dbus $ go test -cpu=1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1...

Just changing the module name doesn't seem right. We'd want a way to maintain both major branches.

No, and I think the JSON package is pretty frozen for new features. But I'll promote this to a proposal. This bug predates the proposal process.

We're using this for our codebase: https://pkg.go.dev/tailscale.com/util/must#Get ```go // Get returns v as is. It panics if err is non-nil. func Get[T any](v T, err error) T { if err...

@rasky, we could keep it there and use something else instead, which might even be unexported. Then we could document that ForkLock is vestigial and should not be used. Is...

@adamdecaf, if they're all guarding `syscall.Socket` or `syscall.Pipe`, we could just make those do the right thing without requiring ForkLock, and keep ForkLock with its existing type, but document that...

Even if we made 100.100.100.100 serve an AAAA record for `192.168.250.70.via-1.foo-bar.ts.net`, that doesn't mean `ping 192.168.250.70.via-1` would use it because that contains too many dots in it for the search...

@danderson, the DNS thing from Perkeep I was remembering was https://github.com/perkeep/perkeep/commit/0273e6c5f54c44bc76055748b70076c0d9ce68a6

@dblohm7, do you know anything about such Windows LLMNR things?