Brian Kroth
Brian Kroth
LGTM, but as @apavlo mentioned, can you please add it to CI tests here so we make sure this gets tested: https://github.com/cmu-db/benchbase/blob/main/.github/workflows/maven.yml#L582 I'm adding it to the rest of them...
Hi @mush-zhang, I merged #519 to enable chbenchmark for most other backends. Can you please update your branch and enable tests following that pattern and let's make sure it passes...
Happy to take a PR :) Main things we would need are - [ ] driver updates to [pom.xml](../tree/main/pom.xml) - [ ] sample configs. See [configs](../tree/main/configs) for some examples. -...
@alexey-milovidov, btw, if you don't have time to do the PR, but could at least comment with a few pointers on any of the above it could help speed things...
Ah, good point. Didn't read closely enough and initially interpreted this as adding ClickHouse support.
Currently some of the twitter tests are marked as `@Ignore` in part because of some `NullException` errors due to the `tracefile` `xmlConfig` references. It would be nice if this PR...
The `templated` benchmark has an example config in the `data` directory right btw.
Have you looked at the `--json-histograms` output?
> I like this a lot but I don't think the files should go into `data` since we're removing it in #228. This is actually related to #420 where we...
@ranaalotaibiMS , #416 and other recent PRs introduced a lot of changes, especially around standardizing code formatting, so you'll have to rebase your changes on an updated main branch first.