Brian Kroth comments

Results 182 comments of


                                            Brian Kroth

Standardize SQL PrettyPrinter + Generic DDLs

@jcamachor fyi

Add SqlServerCollector for metrics

Enable advanced monitoring for SQLServer & Postgres.

Should enable this in the CI pipelines as well so it gets checked. Have a look here for some examples: https://github.com/cmu-db/benchbase/blob/main/.github/workflows/maven.yml#L294

Enable advanced monitoring for SQLServer & Postgres.

@ranaalotaibiMS here's the PR I was mentioning. Could potentially extend this to optionally support plan capture as well.

Inquiry about the purpose of the serial workload parameter

`seial` runs each of the queries listed in that `work` phase sequentially, without inter-query parallelism (there could be intra-query parallelism for each query, but that's a DB specific property). And...

Fix faulty INSERT test query from the templated benchmark example introduced in #386 since it results in duplicate keys

@ETHenzlere can you please take a look at this?

Fix faulty INSERT test query from the templated benchmark example introduced in #386 since it results in duplicate keys

@anjagruenheid for visibility

Fix faulty INSERT test query from the templated benchmark example introduced in #386 since it results in duplicate keys

See Also: https://github.com/cmu-db/benchbase/pull/427/commits/7d4e90b2b6fd72eaf86dc4669da594768a7ff8c0

use threadlocal random generator to avoid contention

> > Would be good if we allowed setting consistent seeds throughout the stack and this seems to exacerbate that issue. > > As far as I know, thread local...

Nullable parameter handling for Templated Benchmarks

@ETHenzlere did this get fixed by #386 ?