benchbase
benchbase copied to clipboard
Introduce session setup
This PR introduces functionality for configuring a session by executing predefined statements before the benchmark execution begins. Users should specify the file containing these statements within the tag <sessionsetupfile> </sessionsetupfile> in the benchmarks' config files. CC: @bpkroth
For example,
<?xml version="1.0"?>
<parameters>
<!-- Connection details -->
<type>sqlserver</type>
...
<!-- Session setup statements file -->
<sessionsetupfile>config/sqlserver/session_setup_sqlserver_cmds_example.sql</sessionsetupfile>
...
I like this a lot but I don't think the files should go into data since we're removing it in #228.
This is actually related to #420 where we need to have DBMS-specific configurations.
I like this a lot but I don't think the files should go into
datasince we're removing it in #228. This is actually related to #420 where we need to have DBMS-specific configurations.
Agree with you on this one - it's DB specific so can/should just go in the DB's config directory.
However, there are a few places where we do have non-DB specific files in that data directory (e.g., templated example config).
Could just duplicate them or find another place to put them.
@ranaalotaibiMS , #416 and other recent PRs introduced a lot of changes, especially around standardizing code formatting, so you'll have to rebase your changes on an updated main branch first.
@ranaalotaibiMS , #416 and other recent PRs introduced a lot of changes, especially around standardizing code formatting, so you'll have to rebase your changes on an updated main branch first.
@bpkroth : Rebased
@ranaalotaibiMS, seems like there are some missing formatting changes. Can you please address those along with the requested example config for testing changes? Thanks!
@ranaalotaibiMS, seems like there are some missing formatting changes. Can you please address those along with the requested example config for testing changes? Thanks!
Tackled this and added a few more small checks. Will merge after the CI passes and add documentation for the config option during #599