benchbase icon indicating copy to clipboard operation
benchbase copied to clipboard

Introduce session setup

Open ranaalotaibiMS opened this issue 1 year ago • 5 comments

This PR introduces functionality for configuring a session by executing predefined statements before the benchmark execution begins. Users should specify the file containing these statements within the tag <sessionsetupfile> </sessionsetupfile> in the benchmarks' config files. CC: @bpkroth

For example,

<?xml version="1.0"?>
<parameters>

    <!-- Connection details -->
    <type>sqlserver</type>
...
    <!-- Session setup statements file -->
    <sessionsetupfile>config/sqlserver/session_setup_sqlserver_cmds_example.sql</sessionsetupfile>
...

ranaalotaibiMS avatar Dec 12 '23 05:12 ranaalotaibiMS

I like this a lot but I don't think the files should go into data since we're removing it in #228. This is actually related to #420 where we need to have DBMS-specific configurations.

apavlo avatar Dec 12 '23 18:12 apavlo

I like this a lot but I don't think the files should go into data since we're removing it in #228. This is actually related to #420 where we need to have DBMS-specific configurations.

Agree with you on this one - it's DB specific so can/should just go in the DB's config directory.

However, there are a few places where we do have non-DB specific files in that data directory (e.g., templated example config).

Could just duplicate them or find another place to put them.

bpkroth avatar Dec 14 '23 22:12 bpkroth

@ranaalotaibiMS , #416 and other recent PRs introduced a lot of changes, especially around standardizing code formatting, so you'll have to rebase your changes on an updated main branch first.

bpkroth avatar Dec 14 '23 22:12 bpkroth

@ranaalotaibiMS , #416 and other recent PRs introduced a lot of changes, especially around standardizing code formatting, so you'll have to rebase your changes on an updated main branch first.

@bpkroth : Rebased

ranaalotaibiMS avatar Jan 03 '24 01:01 ranaalotaibiMS

@ranaalotaibiMS, seems like there are some missing formatting changes. Can you please address those along with the requested example config for testing changes? Thanks!

bpkroth avatar Jan 23 '24 17:01 bpkroth

@ranaalotaibiMS, seems like there are some missing formatting changes. Can you please address those along with the requested example config for testing changes? Thanks!

Tackled this and added a few more small checks. Will merge after the CI passes and add documentation for the config option during #599

bpkroth avatar Feb 13 '25 21:02 bpkroth