benchbase
benchbase copied to clipboard
Standardize SQL PrettyPrinter + Generic DDLs
-
We should use a prettyprinter for the
SQLStmtqueries and DDL files. I did this for the TPC-H queries because the old formatting was atrocious. But I was not able to find an online prettyprinter that had the right formatting.- There is some old code from H-Store where I use a Java constant for table names. I forget why I did this but we don't need it anymore. Example: https://github.com/cmu-db/benchbase/blob/59a7a7dc03d3cdc896491db7f1c1338f5e093231/src/main/java/com/oltpbenchmark/benchmarks/tatp/procedures/DeleteCallForwarding.java#L33
- It would be nice if we could make sure DDL files are formatted correctly automatically.
- We don't need to worry about dialect files (for now).
-
We need to make sure that the generic DDLs do not use
DROP TABLE...CASCADE. This is a minor thing that is not supported in SQLite. We should probably codify the rules of what is the minimum SQL features for these DDL files. @timveil already did the right thing and made it so that MySQL is no longer assumed to be the generic DDL.