Ben Bond-Lamberty

Deal with remaining nonfunctional testing files

2

As they are fixed, remove from the Makefile exclusion list. See https://github.com/JGCRI/hector/pull/449#discussion_r664498533

Permafrost

1

Infrastructure: permafrost data structures, output, etc. Passes all tests. Not integrated into runtime C cycle yet.

Pre-commit hook or test for C++ code formatting?

1

As noted [here](https://github.com/JGCRI/hector/pull/634#issuecomment-1197414953) in #634 , we could enforce C++ coding style by either a pre-commit hook or a test. Right now this seems like overkill, but opening this issue...

https://www.sciencedirect.com/science/article/pii/S2590332222003268

Suggestion by @trevorkeenan in our meeting yesterday. This would be straightforward to implement, interesting to test, and might be a great project for a SULI or programming-inclined postbac/postdoc.

Remove cout calls from ocean_csys - lines 162-177

2

Package build reports: ``` * checking compilation flags used ... OK * checking compiled code ... NOTE File ‘hector/libs/hector.so’: Found ‘__ZNSt3__14coutE’, possibly from ‘std::cout’ (C++) Object: ‘ocean_csys.o’ Compiled code should...

Final cleanup before v3 merge (running list)

4

- [ ] Clean up GitHub Actions yaml files to remove development branch settings - [ ] Ensure all v3 milestone issues are linked, addressed, or reassigned to a new...

DOECLIM variables & time series

5

These guys: ```cpp std::vector temp; std::vector temp_landair; std::vector temp_sst; std::vector heatflux_mixed; std::vector heatflux_interior; std::vector heat_mixed; std::vector heat_interior; std::vector forcing; ``` _really_ should use the Hector time series class. On a...

Consolidate GA files?

3

The GitHub Actions `leeyabot` and `test-coverage` have very similar setups, both needing R, libcurl, and a few packages. Maybe consolidate them into a single yaml file? That would save on...

In #459 @dawnlwoodard noted: >As a side note (should this be a separate issue?), the fluxes don't exactly match the difference in the atmosphere values from year to year. Seems...