hector icon indicating copy to clipboard operation
hector copied to clipboard

Remove cout calls from ocean_csys - lines 162-177

Open bpbond opened this issue 2 years ago • 2 comments

Package build reports:

* checking compilation flags used ... OK
* checking compiled code ... NOTE
File ‘hector/libs/hector.so’:
  Found ‘__ZNSt3__14coutE’, possibly from ‘std::cout’ (C++)
    Object: ‘ocean_csys.o’
Compiled code should not call entry points which might terminate R nor
write to stdout/stderr instead of to the console, nor use Fortran I/O
nor system RNGs.

bpbond avatar Jun 16 '22 04:06 bpbond

Also

❯ checking dependencies in R code ... NOTE
  Namespace in Imports field not imported from: ‘BH’
    All declared Imports should be used.

bpbond avatar Jun 16 '22 04:06 bpbond

Also

❯ checking if this is a source package ... WARNING
Warning:   Subdirectory ‘src’ contains:
=    carbon-cycle-model-31eb9b52.o.tmp core-18563459.o.tmp
  These are unlikely file names for src files.

Fixed this one in #619

bpbond avatar Jun 16 '22 04:06 bpbond

@bpbond it doesn't look like there are any cout calls in ocean_cycs.cpp okay to close?

kdorheim avatar Nov 08 '22 01:11 kdorheim

Okay! Thanks for checking.

bpbond avatar Nov 08 '22 01:11 bpbond