Ben Bond-Lamberty
Ben Bond-Lamberty
It seems like this is a fine change to make, in particular given upcoming base year update work that has the goal of making this all much more robust (see...
For example, either ``` R loadCMIP5(file='ph_Oyr_MPI-ESM-MR_historical_r2i1p1_1960-1969.nc') ``` or ``` R loadCMIP5.file('ph_Oyr_MPI-ESM-MR_historical_r2i1p1_1960-1969.nc') ```
Sorry about that @serbinsh . It's true that, since discovering [CDO](https://code.mpimet.mpg.de/projects/cdo), neither @ktoddbrown nor I have invested much time in RCMIP5. Reopening this to remind us to update the documentation/manual.
I definitely agree that this may be a good candidate. Tagging @pkyle for his thoughts on how much _more_ for this is out there.
>For me, this is the top of the stack of things to fix once all chunks are translated and the output replicates. ~~This is really important and I don't want...
How depressing. An issue to remind us to create issues 😆
Pass :) Are there simpler sanity checks that we could do?
New `test_file_encoding.R` file from #868 : ```R # Test that files are encoded correctly (line endings, blank final line) context("file_encoding") test_that("inputs are encoded correctly", { root
And `test_normalizer.R`: ```R context("normalizer") test_that("input file normalizer works", { # Copy our test files to a temp directory td
>This comes up across the data system - we measure things in Mt but then use enough decimal places to imply that we have knowledge of quantities at the kg...