Ben Bond-Lamberty
Ben Bond-Lamberty
@richfitz Thanks for the information, and ah, didn't realize you wouldn't see the above message. I ask because I'd like to use `datastorr` for a project very similar to [BAAD](https://github.com/dfalster/baad)...
Huh thanks @1beb ! `pins` definitely looks interesting.
Confirming that this is the last PR before issuing v2.1alpha tag.
Cool—thanks @kdorheim
> it looks like the c pools (veg, detritus, and soil) are updated with luc emissions already right? So does this change now cause a double counting of the luc...
@ssmithClimate thanks, and right, it definitely can get tricky—NPP _might_ not drop. But even if it didn't, the duplication-of-regrowth issue, along with the pave-the-amazon scenario (cf. #531 ), plus the...
@dawnlwoodard > soil still has an odd amount of regrowth happening Probably because we're _not_ taking out the LUC pulse proportionately? I.e., we're still following Hector's default (more realistic, I...
@dawnlwoodard Temporarily shifted to proportional LUC losses/gains in 3b40525 ; haven't tested except yes it runs, but should do what you want.
Fixed every test issue except for the old-new test; that'll be the last change, when everything else is resolved. Thanks @dawnlwoodard — interesting to see the graphs above! On the...
@dawnlwoodard OK, I have fixed and merged ( #644 ) ANOTHER bug that your work has uncovered! 👏 The LUC pulse test now matches your spreadsheet I think — see...