Benjamin Pasero

Results 424 comments of Benjamin Pasero

I see no issues in macOS 15.

@connor4312 We still reference or check for macOS/Linux in these places: https://github.com/microsoft/vscode/blob/08e2cba35a1c39b3d321b73e102f6a88b47907f5/src/vs/base/parts/sandbox/electron-sandbox/globals.ts#L80 https://github.com/microsoft/vscode/blob/08e2cba35a1c39b3d321b73e102f6a88b47907f5/src/vs/workbench/electron-sandbox/desktop.contribution.ts#L148

I am a little bit worried about the consequences this change has, in 2 areas: * startup time (since we now launch a PowerShell process on startup) * use of...

@connor4312 great idea, I have https://github.com/microsoft/vscode-perf/pull/46 open to add the flag, I am curious to even see the impact on Linux/macOS. > we make the first call to start resolving...

@connor4312 I think we could still probe via file service if a profile file exists to avoid the extra call by checking for common locations.

Here is a comparison of VS Code resize performance in Electron vs Web. Notice the delay in Electron: **Electron:** ![Recording 2023-11-23 at 09 10 01](https://github.com/electron/electron/assets/900690/94b9fd58-f5df-4229-8234-085e333e2937) **Web:** ![Recording 2023-11-23 at 09...

@nkallen this indeed seems to improve the resize jank. I am still wondering though why for VS Code for example, its so much worse in Electron vs. Chrome, where the...

Can you share a minimal extension sample for how to get into this state with custom folders based on query params?

Thank you for the steps, I can confirm! But I disagree this is a problem specific to breadcrumbs. In more general, we are not supporting workspace folders well that only...