Benjamin Pasero

Results 228 comments of Benjamin Pasero

No this: Compared with stable:

**macOS** Crash is: ``` Thread 0 (crashed) 0 libsystem_kernel.dylib!__pthread_kill + 0xa rax = 0x0000000000000000 rdx = 0x0000000000000000 rcx = 0x00007ffee3e058e8 rbx = 0x000000010f7d3e00 rsi = 0x0000000000000006 rdi = 0x0000000000000103 rbp...

I am having a hard time to get a stack for the Linux ones even after taking the Linux x64 symbols from https://github.com/microsoft/vscode-electron-prebuilt/releases/download/v19.1.8/insiders-symbols-v19.1.8-linux-x64.zip

Keep in mind that there maybe platform differences as well and we try to align with the OS guidelines. I think Windows puts primary button to the left and Linux...

This makes working on Windows really awful for me, I think the upstream bug is fixed.

@deepak1556 > To give some context, with WCO chromium has a bug in orienting devtools window when docked to the position where the Window controls are I see this as...

@deepak1556 but then our instructions are not correct right? can we please update them to explain how to do this step by step? thanks!

@meganrogge `windowImpl` is still in `electron-main` and has access to Electron `app` module, see for example: https://github.com/microsoft/vscode/blob/b92894493e6f971a3c71912d823e699d3a05d643/src/vs/platform/windows/electron-main/windowImpl.ts#L485 Same goes for `windowsMainService` if we want to put this into the config....

@meganrogge there is a way to update the configuration explicitly when doing a window reload, see here: https://github.com/microsoft/vscode/blob/422b581e3802e30cfb780c21d9cc1a2cd0c9f0aa/src/vs/platform/windows/electron-main/windowImpl.ts#L1043 For example we update some properties here: https://github.com/microsoft/vscode/blob/422b581e3802e30cfb780c21d9cc1a2cd0c9f0aa/src/vs/platform/windows/electron-main/windowImpl.ts#L1069-L1070 I would think we...

@meganrogge theming might do something very special for other reasons, do not take it as an example. The values of the environment service will be updated based on the main...