Ben Parees

Results 92 comments of Ben Parees

@aweiteka might be missing doc. @ironcladlou do we not have doc for mid-hooks?

we probably need to see an example of how those labels will actually look with values. Presumably it's going to be a giant blob of json (that defines a hook),...

pretty sure this is dead code since we moved the ruby builder to openshift/ruby-19-centos.

@juanvallejo @fabianofranz is this something you guys would be willing/able to do? The buildconfig has resources fields already. (i'm going to take @juanvallejo's self assignment of this as a yes....

I'm pretty sure we can't actually change this behavior now, but we should at least fix the docs to clarify what happens in each of these scenarios (and make sure...

> In what scenario would running language detection still be valid when you have that image/repo case and know the image is a builder image, such that you can't change...

@coreydaley yeah builder images are s2i-enabled images. here's the new-app codes that decides if an image is an (s2i) builder image or not: https://github.com/openshift/origin/blob/master/pkg/generate/app/builder.go#L12-L35 there are a couple things it...

@szpak you can't force the source type (and then let new-app pick an image for that source type), unfortunately, but if you know of an image can build your source...