origin icon indicating copy to clipboard operation
origin copied to clipboard

[release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready

Open openshift-cherrypick-robot opened this issue 1 year ago • 16 comments

This is an automated cherry-pick of #27224

/assign simonpasquier

@openshift-cherrypick-robot: Bugzilla bug 2079679 has been cloned as Bugzilla bug 2108978. Retitling PR to link against new bug. /retitle [release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready

In response to this:

[release-4.11] Bug 2079679: pkg/monitor: wait for Prometheus sidecars to be ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jul 20 '22 07:07 openshift-ci[bot]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2108978, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2079679 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2079679 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact: /cc @juzhao

In response to this:

[release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jul 20 '22 07:07 openshift-ci[bot]

/hold

it looks like we're having a following issue which is that the function retrieving the alerts from Thanos receives a canceled context.

https://bugzilla.redhat.com/show_bug.cgi?id=2108192 https://issues.redhat.com/browse/TRT-384

simonpasquier avatar Jul 26 '22 08:07 simonpasquier

/retest

simonpasquier avatar Jul 27 '22 16:07 simonpasquier

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node-upgrade fd559209dfbc392f2b195030adc7eae6e6916bf3 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-aws-single-node fd559209dfbc392f2b195030adc7eae6e6916bf3 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 27 '22 19:07 openshift-ci[bot]

/bugzilla refresh

simonpasquier avatar Aug 08 '22 15:08 simonpasquier

/hold cancel

simonpasquier avatar Aug 08 '22 15:08 simonpasquier

@simonpasquier: This pull request references Bugzilla bug 2108978, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "4.11.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 08 '22 15:08 openshift-ci[bot]

/bugzilla refresh

simonpasquier avatar Sep 12 '22 08:09 simonpasquier

@simonpasquier: This pull request references Bugzilla bug 2108978, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.z) matches configured target release for branch (4.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2079679 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2079679 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact: /cc @juzhao

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 12 '22 08:09 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sthaha Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval by writing /assign @spadgett in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 13 '22 07:09 openshift-ci[bot]

@bparees could you have a look at this please?

simonpasquier avatar Sep 13 '22 07:09 simonpasquier

/label backport-risk-assessed /label cherry-pick-approved

bparees avatar Sep 13 '22 13:09 bparees

@bparees: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed /label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 13 '22 13:09 openshift-ci[bot]

@bparees: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed /label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 13 '22 13:09 openshift-ci[bot]

/label qe-approved

juzhao avatar Sep 19 '22 02:09 juzhao

/skip

@bparees sorry to bother you again, would you mind adding the /approve label too?

simonpasquier avatar Sep 27 '22 07:09 simonpasquier

/approve

bparees avatar Sep 27 '22 13:09 bparees

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, openshift-cherrypick-robot, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 27 '22 13:09 openshift-ci[bot]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2108978 has been moved to the MODIFIED state.

In response to this:

[release-4.11] Bug 2108978: pkg/monitor: wait for Prometheus sidecars to be ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 27 '22 15:09 openshift-ci[bot]