ContainerApplicationGenericLabels icon indicating copy to clipboard operation
ContainerApplicationGenericLabels copied to clipboard

add openshift labels for app deployment

Open aweiteka opened this issue 8 years ago • 8 comments

aweiteka avatar Apr 21 '16 16:04 aweiteka

cc @bparees @brianwcook

aweiteka avatar Apr 21 '16 16:04 aweiteka

@bparees I didn't see docs on mid hooks. Do I have the right hook type in mind?

aweiteka avatar Apr 21 '16 16:04 aweiteka

@aweiteka might be missing doc. @ironcladlou do we not have doc for mid-hooks?

bparees avatar Apr 21 '16 16:04 bparees

we probably need to see an example of how those labels will actually look with values. Presumably it's going to be a giant blob of json (that defines a hook), which seems unfriendly but is going to be the most flexible option....

bparees avatar Apr 21 '16 16:04 bparees

There's a documentation gap around mid hooks. They're supported only by the Recreate strategy. The docs for mid will should look the same as for pre and post: https://docs.openshift.org/latest/dev_guide/deployments.html#recreate-strategy

ironcladlou avatar Apr 28 '16 20:04 ironcladlou

Mid hooks docs issue pointing to implementation PR: https://github.com/openshift/openshift-docs/issues/1779

aweiteka avatar Apr 28 '16 20:04 aweiteka

We could add cmd and args labels but relying on the Dockerfile for those is probably less confusing.

aweiteka avatar Apr 28 '16 21:04 aweiteka

@brianwcook updated.

aweiteka avatar May 02 '16 18:05 aweiteka