Jeremy Reizenstein

Results 197 comments of Jeremy Reizenstein

For implicitron e.g. those things, you should ignore readthedocs, and look at the documentation in the code or on github. The implicit functions which have documentation at https://pytorch3d.readthedocs.io/en/latest/modules/renderer/index.html are in...

Sorry about that. Just don't rely on readthedocs? It should be easy to read the documentation on github by clicking on the relevant files.

You are right that the "shading" functions and lighting capabilities in pytorch3d are for meshes and not for point clouds. It is possible for a user to implement their own...

Wow! Impressive work! I'm afraid it may take a while to get all these things landed, because we are busy with other things. Some minor things which would help: -...

You need to install more windows SDKs, perhaps you can do this in the visual studio installer. This was mentioned on https://github.com/facebookresearch/pytorch3d/issues/1553 .

How did you install PyTorch3D? Can you start again in a new conda environment following the recommended steps (https://github.com/facebookresearch/pytorch3d/blob/main/INSTALL.md) to install a prebuilt conda package?

I'm worried about very small angles here. The current implementations delegate to other functions which are being really careful about nasty angles.

Can you explain more about your set up? There is no release of pytorch with cuda 12.1. Did you build pytorch from source? If so, then if you build pytorch3d...

We were discussing this on #1419 . I don't think this is the right kind of change. But also I don't really understand the problem you are trying to solve....

When you say you "consider this a bug", do you mean the behaviour of pip or this issue in pytorch3d? Unless someone can clearly explain how not to break things...