Brandon Ording

Results 94 comments of Brandon Ording

#739 Was my first PR to reduce the public API surface, but I believe there are still more things that make sense to internalize. I'll be looking at those in...

I did want to make one more pass and see if there was any more cleanup that was worth doing, but I just haven't had the spare time to do...

> How about by the end of March? That should work!

> #739, #763 and #783 appear to have addressed most of this. I reviewed the API approval file to see if anything else seemed like obvious candidates for removal. I...

That's a bad design to expose the `ushort` value like that and then need a completely separate, unrelated constants class like to interpret it. The public ReplyCode should be an...

> I've created new commits, fixed some other things which was commented by @danielmarbach (See comments here: You should make your commits on a separate branch and open a draft...

I think we should consider if we want to continue with using interfaces as the public API. They make evolving the API in a non-breaking way difficult, unless we can...

> I think all options should be considered. What would make sense in your mind? Do you mean mostly for the core functionality or also for other extensibility? Looking at...

Any reason not to move this from `interface IChannel` to `class Channel`?

> This is something that I feel the library itself could do automatically. For example, when putting the channel in ConfirmSelect mode, calling BasicPublish wouldn't return until the publisher confirm...