Bo Chen

Results 19 comments of Bo Chen

@ojura this was reviewed and approved a long time ago but somehow not merged. It is now outdated and has many conflicts. Do you still have time to resolve the...

Hi @kingsimba , thank you for your contribution. can you please sign your commits? The easiest way is to use git commit --amend --no-edit --signoff. See https://github.com/cartographer-project/cartographer/blob/master/CONTRIBUTING.md for details. Thanks!

Here a stacktrace i was able to capture, we've since upgraded to the latest released debian package version, but it is still occasionally happening: ``` #0 0x0000000000000000 in ?? ()...

> Thanks for reporting! > > > > Are you calling `shutdown` explicitly in your destructor? (even without the try/catch block). > > > > https://github.com/ros-industrial/ros_canopen/commit/1acd49381d114f4444122732ba53370af621761b should have improved the...

Hi, thank you for your contribution - may I ask you to sign off your commits? Please have a look here for how to fix it: https://github.com/cartographer-project/cartographer_ros/pull/1641/checks?check_run_id=2756820741

This would be really useful - I would strongly vote for this to be merged! I would also propose to add this functionality to the CombinedRobotHW class

@bmagyar added a very basic test to it. I guess could also be very useful in conjunction with https://github.com/ros-controls/ros_control/pull/294 to then automatically attempt to recover / stop

At the moment I use this in the main loop and then attempt to recover / stop if it returns true.

No, there is no interface for that yet - that's why I would like to see https://github.com/ros-controls/ros_control/pull/294 being extended to combined_robot_hw and also merged. Maybe add the extension of stop...