ros_control icon indicating copy to clipboard operation
ros_control copied to clipboard

Add method to check for error in robotHW component

Open bochen87 opened this issue 6 years ago • 9 comments

I'm proposing to add a method to check for errors in the hardware components, especially when having multiple HW components, it becomes quite cumbersome otherwise.

bochen87 avatar Sep 17 '18 13:09 bochen87

Could you please demonstrate an example use-case, perhaps through some unit tests?

bmagyar avatar Sep 25 '18 22:09 bmagyar

@bmagyar added a very basic test to it. I guess could also be very useful in conjunction with https://github.com/ros-controls/ros_control/pull/294 to then automatically attempt to recover / stop

bochen87 avatar Oct 04 '18 12:10 bochen87

Who would call this hasError function and why?

mathias-luedtke avatar Oct 04 '18 13:10 mathias-luedtke

At the moment I use this in the main loop and then attempt to recover / stop if it returns true.

bochen87 avatar Oct 04 '18 13:10 bochen87

attempt to recover / stop if it returns true.

This is the interesting part.. I believe there are no interfaces for this yet. In ros_canopen I poll and command the hardware directly.

mathias-luedtke avatar Oct 04 '18 13:10 mathias-luedtke

No, there is no interface for that yet - that's why I would like to see https://github.com/ros-controls/ros_control/pull/294 being extended to combined_robot_hw and also merged. Maybe add the extension of stop / recover to combined_robot_hw and the error checking interface in one PR?

bochen87 avatar Oct 04 '18 13:10 bochen87

@bmagyar @ipa-mdl any thoughts?

bochen87 avatar Dec 05 '18 14:12 bochen87

Would just like to throw this out there in case nobody has considered it, but it appears the API is converging on an orocos component like design

jlack1987 avatar Jan 02 '19 16:01 jlack1987

@bmagyar @ipa-mdl any thoughts?

Bump

bochen87 avatar Feb 10 '22 08:02 bochen87