Bob Silverberg

Results 118 issues of Bob Silverberg

I notice that `device.type` can be one of `console, mobile, tablet, smarttv, wearable, embedded`, but for a desktop browser it just returns `undefined`. Is there a reason that decision was...

The latest version of redux marks the core redux as deprecated and suggests using @reduxjs/toolkit instead. I have taken a look at the latter and it is indeed a great...

component: code quality
priority: p3

This was discovered during the investigation of https://github.com/mozilla/addons-server/issues/17362. According to @diox: "We have configured Elasticsearch in a way that doesn't allow pagination to go past 25000 items (1000 pages of...

contrib: welcome
priority: p3
neverstale

There is some code in `webpack.dev.config.babel.js` that loads unminified versions of the React libraries when we are running in development. The comment around this code says: ``` // Load unminified...

component: code quality
priority: p3

As discussed on Slack, and also mentioned in https://github.com/mozilla/addons-frontend/issues/11730#issue-1305152697, there are likely a number of tests in our suite that could generate false positives if bugs arise in our code...

component: code quality
component: testing
qa: not needed
priority: p3

React 18 has near-complete support for `Suspense` on the server (for SSR), but in order to take advantage of this we'd need to migrate from using `renderToString` to using `renderToPipeableStream`....

platform: server
priority: p4

We should update to the latest redux-saga. Renovate has a PR open at https://github.com/mozilla/addons-frontend/pull/10931, but this may be a large task, so it might need this as a tracking issue.

component: code quality
priority: p3

Now that we've modernized the test suite, it would make sense to take a moment to look at any missing coverage we have, and add coverage in places where it...

component: code quality
component: testing
priority: p3

When converting TestScreenShots.js, I have been unable to get a test working that tests the functionality implemented via the `onOpenPhotoswipe` function. We cannot write a test the way we did...

component: code quality
component: testing
priority: p3

Migrate /reducers/test_search.js from Sinon to Jest

component: testing
priority: p3