Bob Silverberg

Revisit the logic around couldShowWarning in InstallWarning

2

Quoting willdurand in https://github.com/mozilla/addons-frontend/pull/8348#discussion_r312547172, "I am not sure to like this pattern. Could you file an issue so that we can discuss it and maybe revisit it later?" ┆Issue is...

Editing a reply from the permalink page opens two text boxes

1

STR: 1. Log in as an admin (or developer) and go to the list of reviews for an add-on. 1. Add a reply to one of the reviews. 1. Click...

Left-align review controls for wider cards

3

* Sign in * Go to an add-on detail page * Rate the add-on * Write a review and submit it The _Edit review_ and _Delete review_ links should be...

Remove the ability for an administrator to reply to a review

11

**UPDATE:** I have kept the original description below for context. This issue is now about removing the ability for a non-author to reply to a review. This will be implemented...

Consider having two different actions for adding an add-on to a collection

4

An add-on can be added to a collection from two different places, both of which dispatch an `addAddonToCollection` action: 1. From the [`AddAddonToCollection`](https://github.com/mozilla/addons-frontend/blob/77f3787cd4d7b08f39c8a87ce1cca96548ccf6a3/src/amo/components/AddAddonToCollection/index.js#L122) component, which is rendered as part of...

Have bot respond to its nick when automatically renamed on connect

1

We have found that sometimes, when the bot is cycled, it reconnects to the room before its old nick is released, and therefore reconnects with a different, deduplicated nick. E.g.,...

Problem with linter message navigation for files without changes

1

This is a follow-up to https://github.com/mozilla/addons-code-manager/pull/824#discussion_r292206253, which was meant to be fixed by https://github.com/mozilla/addons/issues/6736 but appears to not have been. Here are some observations: - Starting at http://localhost:3000/en-US/compare/502868/versions/1541685...1688183/?path=src%2Fjs%2FGrammarly.js, pressing `a`...

With the upgrade to Storybook v6, the behaviour has changed so that errors that occur when generating the stories, which were previously only shown in the browser console, are now...

Allow CodeView to accept a single `file` prop instead of 3 individual props

1

This is a follow-up to https://github.com/mozilla/addons-code-manager/pull/1498. `CodeView` accepts [some props](https://github.com/mozilla/addons-code-manager/blob/master/src/components/CodeView/index.tsx#L64-L68) which are properties of a `VersionFile`. #1498 introduced yet another of those, the `isMinified` prop. It seems like it might...

This is a follow-up to #1454, which introduced a `PerformanceObserver` into the `App` component. I was unable to figure out how to get code coverage for the body of the...