Rob Pilling

Results 198 comments of Rob Pilling

Interesting - I wonder what else might be writing to `width` If you want to check, run this after `sleeplog`'s loaded and you might see an error backtrace when something...

Interesting - let's give it a month or so and see if the bug crops up, if not, I reckon we can close this as a hardware/storage caused issue

Nice spot - that might impact the drawing. On a look through, this leading comma looks a little odd, but wouldn't cause the joined lines you're seeing: https://github.com/espruino/BangleApps/blob/2b8399bb9bd076cae54d675baebf7f89b1eeb8d2/apps/sleeplog/boot.js#L130-L134 Whereas here...

For recorder, I propose we fix this with a change to the logic - currently we'll see if there's [any logs for the current day](https://github.com/espruino/BangleApps/blob/ba082f670c5661894a83c4bb666fcea555d85aec/apps/recorder/widget.js#L260-L264). Instead I propose that we...

I've got a draft fix (#3136), if you'd like to try it out, it's deployed to my [gh pages](https://bobrippling.github.io/BangleApps/?id=recorder). I think the four hours logic will want a setting, but...

Looks like it might be a colour problem - @peerdavid anything like this ring a bell?

Thanks for checking - sounds like it's related to [this espruino commit](https://github.com/espruino/Espruino/commit/eabd13cfb8ce1c0a81708bb6e9f37f15b101a5fd#commitcomment-135446714) and #3144, so should be fixed when [this commit](https://github.com/espruino/Espruino/commit/91e45d60f1693ed61c93c0163b7c30d6168cc7d9) makes it to firmware (v2.20 at a guess)

I guess the [above commit](https://github.com/espruino/BangleApps/issues/3128#issuecomment-1881847696) wasn't the fix, looks like the bug would need some more scrutiny

Nice! Yeah that all looks great, thank you. One thing I'm interested in your opinion on - I think unlike the original lint changes where we wanted to bump app...

Ah of course - great stuff. I think that's perfectly reasonable, let's stick with your approach in that case. And no rush :)