Rob Pilling

Results 198 comments of Rob Pilling

Great, thank you (also tagging #2865 for reference too). I'll tag @gfwilliams just so you're aware, in case there was any storage changes you're working on in the meanwhile

> This will fail if something else replaces `setLCDOverlay`. That might not be problematic since there are limited use cases for doing that? Yeah I think this is safe, I...

> I have thought about extracting the code for handling "background" watches and screen event handlers into a library. Maybe it would be useful in a library for shared overlay...

I like the sound of that, I suppose the promise blocking could be surprising to a user - for example, they've just hidden one overlay, then another pops up immediately...

> Maybe discussion on this would be better visible in a dedicated issue or forum thread? Good idea - #3417

Change looks good btw, thanks!

I've had a skim through the code and noticed a [`width` being used in place of a `height`](https://github.com/espruino/BangleApps/pull/3085), I'm not sure it impacts the exact issue here but I've [deployed...

Thanks for the update and for trying out the patch even so - in that case the issue will be in the drawing code most likely, just an overlap of...

No worries, thanks for confirming - @storm64 I don't suppose you saw anything like this during development of the app?

Ah interesting, like if there's a shift back in time perhaps?