Bob Haddleton

Results 125 comments of Bob Haddleton

This project appears to have been abandoned. You might want to check out the fork of this project - https://github.com/faust-streaming/faust It has a bunch of fixes merged for problems that...

This project appears to have been abandoned. You might want to check out the fork of this project - https://github.com/faust-streaming/faust It has a bunch of fixes merged for problems that...

@tnthornton this looks really useful - however the link to the up-ls repo is broken - it doesn't seem to be a public repo on github.

This issue is also discussed here: https://github.com/crossplane/crossplane-runtime/issues/340 @negz - would it make sense to move the current check after the Observe function call, and if Observe returns successfully (Create is...

@jbw976 Could this be handled in the crossplane-runtime managed.Reconciler instead of being implemented individually in every provider? Considering the managementPolicy work that was done in provider-kubernetes, https://github.com/crossplane-contrib/provider-kubernetes/blob/main/internal/controller/object/object.go#L247 - it just...

Did you run "make" by itself after running git clone? That should set up the build environment so that everything else works. See https://github.com/crossplane/crossplane/blob/master/CONTRIBUTING.md#establishing-a-development-environment

In testing these changes I discovered that the Claim is not defined as an Owner of the Composite - there is no ownerReference in the Composite object pointing at the...

I assume that there is no ownerReference so that the Claim reconciler can handle the composite deletion itself here - https://github.com/crossplane/crossplane/blob/master/internal/controller/apiextensions/claim/reconciler.go#L377 Is there a reason to do the composite delete...

Since the Claim->Composite relationship is being handled explicitly, what about adding another DeletionPolicy value of "Foreground" that only applies to Claims/Composites (it makes no sense to apply it to Managed...