Benjamin Ramhorst
Benjamin Ramhorst
Looks good to me. Would be nice to add a test, just to show correct behaviour. We could do it in a similar way to other activations, in `test/test_keras_api.py`
I agree with the comments, the reason I didn't remove the Softmax layer completely is because in the test we have a simple one-layer network, which if removed, wouldn't really...
> pytest.activations is failing: > > ``` > E AssertionError: > E Not equal to tolerance rtol=0.02, atol=0.02 > E > E Mismatched elements: 8000 / 8000 (100%) > E...
I will add pre-commit additionally, last time I ran it, some tests were broken, so will add it a subsequent commit.
This is ready for review, seems that pre-commit can re-arrange the order of includes in C++ header files and it could cause compilation error.
I had a quick go at this - there are a few non-trivial implementation details, that need to be considered, compared to the current `.h5` file reader. Documentation available at:...