Brandon Williams
Brandon Williams
@tnowacki whats the current state of how we rollout framework changes to mainnet, as in if we land this will this go out to mainnet in 2 weeks? If so,...
I sort of think that's a problem, unless were actually ok with this rolling out to testnet and mainnet. We shouldn't be releasing any new framework code unless we're happy...
Thanks for reporting! There were some issues identified in the indexer that the team is working on fixing. Will report back here once we have a fix
@rootwarp looks like one of the tests (probably unrelated to your change) failed. Would you be able to rebase onto the latest tip of main and we can rerun the...
@rootwarp sorry, looks like rustfmt has decided to complain, mind doing one more tweak?
Closing this stale PR
@nasifimtiazohi I unfortunately no longer have write access to projects in the diem organization so I won't be able to help get this PR landed :(
Iirc we want to migrate all histograms to be Prometheus ones and avoid using the ones defined in Mysten metrics
Ok I've updated the PR to account for the provided feedback. There are still a few outstanding things that I think, and would prefer, would be best to do in...
Also to answer this: > Do we need both resolve and simulate at the REST level? It seems like simulate is offering a strict subset of the features that resolve...