Brandon Williams

CI changes LGTM, but i'll leave it to @junkil-park and @wrwg to decide if they want to move this to land blocking

@wrwg unfortunately it does not yet

This is awesome! Thanks for helping close the loop on this one. As @lxfind mentioned I think it would be wise to include some tests.

Is there more context on why we wouldn't be able to use a loopback address? Also AFAIK gRPC is fundamentally built on top of HTTP/2 so we'd be using http...

I opened an issue in the mysten-infra repo to add support for this: https://github.com/MystenLabs/mysten-infra/issues/73 Once its implemented there we should be able to wire it in in narwhal.

Yeah I would hope that the networking layer/abstraction would be able to just handle this and be transparent to the actual application layer. We'll see how close we can get...

One big challenge with doing this is that all of diffing algorithms currently supported by diffy require that the whole file is in memory so if some functions were modified...

Yes I can see how that would be slightly confusing. The intent of the library is to provide the functionality for diffing/merging files but in order to be more flexible...

I'd be happy to accept any contributions :) That would probably be a good change since it would make the type more interchangeable. I wish there was a set of...

Sounds good! Look forward to seeing it :)