sui icon indicating copy to clipboard operation
sui copied to clipboard

Add mark on addresses command response

Open rootwarp opened this issue 2 years ago • 4 comments

sui client addresses returns several addresses, but it is impossible to recognize which address is activated before trying sui client active-address.

This change adds a simple mark on the active address of the response.

rootwarp avatar Jan 28 '23 14:01 rootwarp

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated
explorer ⬜️ Ignored (Inspect) Feb 14, 2023 at 1:24PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Feb 14, 2023 at 1:24PM (UTC)
frenemies ⬜️ Ignored (Inspect) Feb 14, 2023 at 1:24PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Feb 14, 2023 at 1:24PM (UTC)

vercel[bot] avatar Jan 28 '23 14:01 vercel[bot]

@huitseeker Could you please let me know what should I do for having a review for the first contribution?

rootwarp avatar Feb 02 '23 13:02 rootwarp

@patrickkuo @666lcz @amnn @bmwill may be able to help!

huitseeker avatar Feb 02 '23 20:02 huitseeker

@bmwill @666lcz Can someone let me know what should I do to go to next step?

rootwarp avatar Feb 07 '23 02:02 rootwarp

@rootwarp looks like one of the tests (probably unrelated to your change) failed. Would you be able to rebase onto the latest tip of main and we can rerun the CI.

bmwill avatar Feb 14 '23 00:02 bmwill

@rootwarp looks like one of the tests (probably unrelated to your change) failed. Would you be able to rebase onto the latest tip of main and we can rerun the CI.

@bmwill Thanks for the comment :) I rebased the commits on the lastest main branch.

rootwarp avatar Feb 14 '23 02:02 rootwarp

@rootwarp sorry, looks like rustfmt has decided to complain, mind doing one more tweak?

bmwill avatar Feb 14 '23 03:02 bmwill

@rootwarp sorry, looks like rustfmt has decided to complain, mind doing one more tweak?

@bmwill yeah. I saw fmt fail and I am working to fix this. I will push new commit to resolve this. Thanks for keep reviewing this. 😀

rootwarp avatar Feb 14 '23 03:02 rootwarp

@bmwill I fixed fmt issue and push a new commit(226dee774)

rootwarp@Mindhack2021 ~/g/M/sui cli > cargo fmt --check --all
rootwarp@Mindhack2021 ~/g/M/sui cli >

rootwarp avatar Feb 14 '23 13:02 rootwarp