Brett M. Morris
Brett M. Morris
I wasn't sure if this can/should be tested, so I simply tested it locally on the jdaviz custom template by running: ```python from voila.paths import install_custom_template install_custom_template('../jdaviz', 'jdaviz-default', overwrite=True) ```...
Hi @maartenbreddels, > the PR here looks much larger than what was needed in https://github.com/spacetelescope/jdaviz/blob/main/setup.py#L123-L164 , could you describe the large discrepancy ? If you compare [`jdaviz/setup.py:DevelopCmd.run`](https://github.com/spacetelescope/jdaviz/blob/main/setup.py#L123-L164) with the proposed...
Tested with: ```python import numpy as np from numpy_groupies.aggregate_numba import aggregate import numpy as np x = np.logspace(0, 1, 100000) y = np.random.uniform(size=len(x)) n_groups_max = 6 group_idx = np.sort(np.random.randint(low=0, high=n_groups_max,...
👍🏻 This would be handy for those of us maintaining custom templates like jdaviz.
My two cents: tqdm works great, astropy doesn't need to maintain an alternative. Bin it. 🗑️
If you remove the `format='kepler'` option, you get a table that _almost_ works. The remaining challenge is that the `time` column is parsed as an (N, 2) Time array (with...
Ah and the [astropy docs](https://docs.astropy.org/en/stable/io/unified.html#writing-and-reading-astropy-time-columns) taught me that this can be fixed as well by doing the following: ```python LightCurve.read(path, astropy_native=True) ``` Maybe we should add an example to the...
Any updates? Thanks!
Friendly reminder @rickynilsson.
Writing an issue is always the most clarifying exercise. I was hitting this error because I was using TermConvolution, which uses this line: https://github.com/exoplanet-dev/celerite2/blob/e75dd45ca4f033b22d3ca19d0545a097c7441495/python/celerite2/jax/terms.py#L301-L310 but the jax implementation of `SHOTerm`...