Brett M. Morris

Added some more comments – [please also rebase](https://docs.astropy.org/en/stable/development/workflow/development_workflow.html#how-to-rebase) when you get a chance.

In order to get your [new tests](https://travis-ci.org/astropy/astroplan/jobs/607725794?utm_medium=notification&utm_source=github_status) to pass which rely on `synphot`, you'll need to do a few more small changes: * add a line like the others [here](https://github.com/astropy/astroplan/blob/master/astroplan/conftest.py#L46)...

You'll need to [rebase](https://docs.astropy.org/en/stable/development/workflow/development_workflow.html#how-to-rebase) and then force-push your changes. I recommend you make a backup branch of your work by typing `git branch backup` before you rebase, just in case.

Sorry to leave you hanging so long @tcjansen! * [One test](https://travis-ci.org/astropy/astroplan/jobs/611589029#L1137) is failing because astroquery is not in pip requirements for tests. You might be able to fix this by...

I think it be appropriate to stick a little note on the front page (i.e. [this one](http://astroplan.readthedocs.io/en/latest/index.html)), do you @cdeil?

If you run this addition to your code: ```python import numpy as np times = time + np.linspace(-12, 12, 20) * u.hour for target in targets: max_altitude = max(telescope.altaz(times, target).alt)...

@mcoughlin Just a few more: ``` astroplan/constraints.py:947:69: W291 trailing whitespace astroplan/constraints.py:948:26: W291 trailing whitespace astroplan/tests/test_constraints.py:168:34: W291 trailing whitespace ```

Hi @mcoughlin, Thanks for starting this constraint. In astroplan we try to use full-precision astropy methods wherever possible, so that results from astroplan will agree with doing the calculation "the...

I wonder why it's so slow. Is it possible that a different combination of arguments in the `local_sidereal_time` method would be faster? https://docs.astropy.org/en/stable/time/index.html#sidereal-time-and-earth-rotation-angle

@mhvk We're using `astropy.time.Time.local_sidereal_time` to compute LST in astroplan: https://github.com/astropy/astroplan/blob/67c0c6ba8467fc26ca79a7cef056eb38a066abd2/astroplan/observer.py#L1914C29-L1915 Do you know if there are more performant options to give the LST functions, so that we can compute many...