Bryan Mishkin
Bryan Mishkin
We'll also need to put this behind an option (e.g. `requireArgs`) to avoid this being a breaking change. In a future major version, we could enable the option by default.
@samridhivig I see. Yeah so we only know about the Ember Data issue with `init` needing args right now, but would you mind asking on the Ember Discord or otherwise...
@NullVoxPopuli @patricklx
I'm opposed to adding additional configs. I'd like everything to work properly with simply the recommended config. We have other rules that bail-out in test files.
Can you explain? Why are quotes needed?
Appreciate you looking into this! For the record, I would prefer we `skip` the test with a `TODO` comment linking to the issue to fix it, instead of just changing...
Thanks for the proposal. I generally don't agree with removing rules simply for targeting older versions, as I've described in my full response https://github.com/ember-template-lint/ember-template-lint/issues/2976#issuecomment-1716617693.
Can you file a separate issue for that? ESLint v9 support can be fixed in a bug fix release.
The rule only intends to disallow importing from test file paths (ending in `-test`). It looks like we can just add an allowlist to the rule of common package names...
Yeah that would be a good case to catch. Would require using our `getNodeOrNodeFromVariable()` helper (which uses `findVariable` from `eslint-utils` under the hood) to detect it.