eslint-plugin-ember icon indicating copy to clipboard operation
eslint-plugin-ember copied to clipboard

Published 20 hours ago • verified publisher icon ember-cli

[DEMO] "Fixes" failing CI tests post ember-template-imports upgrade

Open nlfurniss opened this issue 2 years ago • 4 comments

Discussed in #1667. Not meant to be merged

@NullVoxPopuli

nlfurniss avatar Nov 29 '22 21:11 nlfurniss

Can you explain? Why are quotes needed?

bmish avatar Nov 29 '22 21:11 bmish

I dont know yet, just pseudo-figured out the issue and wanted to put this up for reference

nlfurniss avatar Nov 29 '22 21:11 nlfurniss

Appreciate you looking into this! For the record, I would prefer we skip the test with a TODO comment linking to the issue to fix it, instead of just changing the test to pass. Would like to make sure we don't lose track of these failing test cases...(note: we can still add the new passing test case too).

bmish avatar Nov 29 '22 22:11 bmish

Appreciate you looking into this! For the record, I would prefer we skip the test with a TODO comment linking to the issue to fix it, instead of just changing the test to pass. Would like to make sure we don't lose track of these failing test cases...(note: we can still add the new passing test case too).

Yeah this PR wasn't meant to be merged. Will modify it accordingly

nlfurniss avatar Nov 29 '22 22:11 nlfurniss