Bryan Mishkin

Results 359 comments of Bryan Mishkin

Can you provide a code sample that you want to be caught by the rule?

I'm not sure if that should be considered an error. You may want to post the question on the Ember Discord, and let us know what you find out. Either...

Neat! We do accept lint rules related to Ember Data: https://github.com/ember-cli/eslint-plugin-ember#ember-data PR welcome.

@runspired would love to get this rule in still! Are you planning to work on it?

Yeah I agree we should avoid adding `computed.`. But going along with this fix, we'll ideally need to add the import statement for the specific macro if missing. PR welcome.

How do you detect an Ember app, engine, or addon if it doesn't have `ember-app`, `ember-engine`, or `ember-addon`? I assumed that keyword was the source of truth.

I want to note that [npm-package-json-lint](https://github.com/tclindner/npm-package-json-lint) exists and is pretty powerful and mature for these kind of checks, although since it's not an ESLint plugin, it's not something that can...

I think it's an open question whether package.json linting should be incorporated into eslint-plugin-ember. Pretty much all ESLint plugins are focused on linting a single type of file (and almost...

The ember-cli [blueprint](https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/package.json) already includes various JavaScript linters including eslint-plugin-ember, handlebars linting via ember-template-lint, and there's a [proposal](https://github.com/emberjs/rfcs/pull/814) to add stylelint. I'm not sure why package.json linting necessarily belongs in...

How often does someone use eslint-plugin-ember without extending from our `recommended` config? I assume the vast majority of users use our `recommended` config and just disable a few rules they...