python-soxr icon indicating copy to clipboard operation
python-soxr copied to clipboard

Published 20 hours ago • verified publisher icon dofuuz

conda-forge packaging

Open bmcfee opened this issue 2 years ago • 4 comments

:wave: @dofuuz are you at all interested in providing a conda-forge package for this library?

libsoxr itself is already available https://anaconda.org/conda-forge/soxr so there shouldn't be any significant barrier here.

The main benefit of conda-forge packaging this library would be ease of installation and management for downstream projects (eg librosa).

bmcfee avatar Jun 29 '22 17:06 bmcfee

https://github.com/conda-forge/staged-recipes/pull/19495 I made PR to conda-forge.

dofuuz avatar Jul 02 '22 01:07 dofuuz

PR for conda-forge is kind of rejected for now.

Actually, python-soxr is using static link for easy installation, so does not need separate libsoxr . Conda-forge maintainer is requesting (optional) dynamic linking libsoxr. So, it's not likely to be merged into conda-forge for now.

dofuuz avatar Jul 22 '22 00:07 dofuuz

Actually, python-soxr is using static link for easy installation, so does not need separate libsoxr .

I followed that discussion over on the conda-forge PR, but I didn't understand why this has to be static only? As noted over there, conda packages are cross-language, so a dynamic linkage here ought to be fine (preferred even). Seems to me like you can have a static build for pypi and a dynamic build for the conda-forge recipe without causing any major trouble.

bmcfee avatar Aug 05 '22 21:08 bmcfee

@bmcfee Yes, that's right. I'm just quite lazy for implement it. 😉 I'll handle this in near future.

dofuuz avatar Aug 07 '22 00:08 dofuuz

Python-SoXR is now on conda-forge. 🎉 https://anaconda.org/conda-forge/soxr-python https://github.com/conda-forge/soxr-python-feedstock

Note: The Conda package has been named to soxr-python to follow conda-forge's naming scheme.

dofuuz avatar Aug 19 '22 04:08 dofuuz

Awesome! :tada:

bmcfee avatar Aug 21 '22 13:08 bmcfee