Brian McFee

Results 739 comments of Brian McFee

I believe I pulled this formula from the following reference: ``` Poularikas A. D. “Windows ” The Handbook of Formulas and Tables for Signal Processing. Ed. Alexander D. Poularikas Boca...

O_o upon closer inspection, I think we've fallen to [Jenkins' Inequality](https://twitter.com/PaulMineiro/status/1560991328556658688) and interchanged the sum and abs operators in the denominator: ![image](https://user-images.githubusercontent.com/1190540/186170781-01d6eb6a-3544-4580-ae86-00a74e99c8ef.png) Since all of our cached windows (and I...

Interesting, I didn't realize that soundfile had this functionality already. It does seem useful in certain circumstances. I'm not 100% on adding it right now though, mainly because it wouldn't...

Please use the issue template, and provide a minimal example demonstrating the expected and actual behavior in question.

> Please use the issue template, and provide a minimal example **demonstrating the expected and actual behavior** in question.

Here is the exact sequence of steps that will happen here: 1. x will be padded by `n_fft // 2` samples on either side. Call the result `x_pad`. (see `core.stft`)....

Ah, I see what you mean now. I think this all comes down to the amount of left- and right-padding done inside the STFT, and not the framing function per...

Yeah, this all makes sense. I guess if we wanted to make this really precise, we'd minimize `n_right` such that ```python (len(x) + n_fft // 2 + n_right - frame_length)...

> Any progress on this? No, nobody has volunteered to work on this. To reiterate, I don't think there's anything wrong with our implementation and there's no bug to fix...

Possibly related: #695