Brian McFee

Results 473 comments of Brian McFee

Thanks @jordan-lenchitz ! This seems cool, though I'm not sure I fully understand what it means for us. If I get this correctly, what you're proposing is to notate each...

Blocked by #1556

Thanks for opening this! Bare exception catching is not a good practice though. We were catching a specific kind of error from soundfile, which is only raised when there's an...

Thanks for the changes. Having now looked at the linked PR though, I don't think the changes here implement what we want them to do. The PR in question replaces...

> Having a closer look, I was running in a `ThreadPool` (`multiprocessing.pool.ThreadPool`). When I switched to run in a single thread, `RuntimeError` is thrown instead of `ValueError` from `soundfile`. It...

Circling back on this: it looks like the new release on soundfile (0.10.3) includes the new exceptions, so we can go ahead with this for the 0.8.1 release. We'll have...

> Circling back on this: it looks like the new release on soundfile (0.10.3) includes the new exceptions, so we can go ahead with this for the 0.8.1 release. We'll...

> Loading a piece of a longer audio file is much slower in v0.9.2 than it was in v0.8.1. For instance, loading a 2-hour wav file takes 440 ms, and...

Loading with sr=None bypasses all sample rate conversion, so resampy is not a factor here. I'm very puzzled by this behavior. There's nothing in the diff from 0.9.1 to 0.9.2...