Brian McFee

Updating this issue because we need to update almost all gh actions at this point due to node deprecations.

Thanks for the thorough report and sample data. I'm tagging @stefan-balke on this, since he has spent the most time (I believe) with the inner workings of our DTW implementation....

Ok, then I think all we need to do is spend a little time revising the docstring here. I'll leave this issue open in case anyone wants to jump on...

Yeah, I was thinking core.audio with re-export at the top level. I know the top-level is feeling a bit bloated, but I'm not sure there's enough isolated functionality here to...

I have a PR out on mir_eval to add nan support to pitch sonification, and that should roll out in the next release. As such, I'll remove this feature from...

> say `kwargs_stft`, that is a dict of all kwargs for stft. You just pass this directly though without hardcoding any parameter names of any of functions. I'd prefer we...

Looking at this now, I think the simplest thing to do is just rip out the kwargs and make all parameters explicit. This shouldn't break any existing user code, and...

I dug up the code we based this on: https://github.com/dpwe/alignmidi/blob/8497f3165147d4d3e4c52d528f22c5ff41a6dc03/beat2.m#L236-L238 and this looks correct in matlabese, ie the slice is both-sides inclusive. It's possible that we had a slightly different...

Going more into history, we disabled this particular regression test pretty early on (Jan 21, 2014): bfebc9b8f0efc32c9d27687c08860801d2a9d512 - but I'm still not sure why this would have passed prior to...

I don't think I understand the problem here. You're providing an unexpected argument, and the error message says exactly that. What is misleading, or what would you expect it to...