Brian McFee

Results 489 comments of Brian McFee

Nice - thanks for looking into it. I think we might still want / need stub files in some situations though, either because of dependency types from upstream packages, or...

Wow, thanks for this! There's certainly a lot to review here, but so far it looks great. Some responses to your caveats: > I only tested with mypy and Pylance...

> Shouldn't `note: Union[str, Iterable[str]]` do the job nonetheless? Maybe - we'd likely also want to add ndarray since merging #1553 implements multidimensional arrays of strings in these places.

https://sphinx-gallery.github.io/stable/auto_examples/plot_8_animations.html#sphx-glr-auto-examples-plot-8-animations-py shows how to do animations in general.

https://github.com/spatialaudio/python-sounddevice/issues/431 has some ideas for how to arrange a virtual device via jack

Ah, looks like this dependency update no longer works with python 3.6. I suppose this forces our hand in bumping to 3.7 minimum. Since this forces us up to 3.7,...

Ok, we're now deep in dependency hell with the minimal environment. Losing steam on working this out for now, will resume later on.

I got this to work in a 3.7 environment by bumping the following minimum versions: ``` - numpy==1.20.3 # up from 1.17.0 - scikit-learn==0.20.0 # up from 0.19.1 - decorator==4.3.0...

Looks like all tests pass and the local doc build works. I think this is ready to :shipit:

This is nearly impossible to debug directly, but something you might want to try is replacing `import librosa` by `import X` for each of the core dependencies listed in the...