Brian McFee
Brian McFee
> That's why mypy encourages the 'gradual typing' use case. My personal suggestion is to make sure new code is typed correctly from now on (e.g. if you're using VS...
> Personally I don't think it's that ugly actually, it clarifies an assertion that was previously implicit (that the if/elif branches cover all possible cases). Sure, but a comment could...
Just to follow up with a concrete example. mypy's doing the following: ``` librosa/beat.py:348: error: Slice index must be an integer or None [misc] ``` The offending code block is...
@matangover I'm still hacking through mypy errors, and wondering about the ScalarOrSequence type. It seems like this is what the numpy [ArrayLike](https://numpy.org/doc/1.20/reference/typing.html#numpy.typing.ArrayLike) type is for - is there a reason...
Looking back upon this today, it seems that the sounddevice folks have examples for stream-processing from ffmpeg output, which I think should do the trick nicely for us. https://python-sounddevice.readthedocs.io/en/0.4.6/examples.html#play-a-web-stream
It seems unlikely that we'll get a proper CR on this admittedly *very large* PR. However, I think it's A) reasonably stable, and B) fringe enough functionality that changes down...
Given the :cricket: sounds here, I'm going to go ahead and merge this tomorrow (11/10) unless there are objections.
Note: coverage dip here is because our CI builds are now exclusively using libsndfile for all formats and no longer hitting the audioread fallback. That's independent of the current PR,...
Just added a few last cleanups to documentation to better cover scalar/vector support and one more test.
:wave: just chiming in to note that we're also observing this behavior here (spleeter 2.3.2). Not sure if this is a dupe of #809 but it certainly seems related.