Benoit Marty
Benoit Marty
Hello @jmartinesp I believe that we can we close this issue?
@ofalvai can I ask you to handle https://github.com/vector-im/element-android/pull/5846#discussion_r1065824274? Then we could merge this PR. Thanks!
The `gitBranchName` has been moved (in #3381) and is now set here: https://github.com/element-hq/element-x-android/blob/main/app/build.gradle.kts#L301 ```kotlin val gitBranchName = providers.of(GitBranchNameValueSource::class.java) {}.get() ``` I guess the trick at https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/io.element.android.x.yml#L40 need to be updated...
There is no way to "ignore" that difference?
Good to see the progress, thanks @licaon-kter ! We have release 0.6.2 on the PlayStore: https://github.com/element-hq/element-x-android/releases/tag/v0.6.2, if you want to try again the F-Droid build using this version...
We made a security release, the build has been done locally on a private branch. I'll update the release with the correct F-Droid APKs.
@licaon-kter I have updated the release https://github.com/element-hq/element-x-android/releases/tag/v25.04.2
We are just mapping what the SDK is providing to the application here. There is maybe a problem in the SDK then?
Yes, I have read it too fast, my bad The mapping I have done [in the EventContentMapper](https://github.com/element-hq/element-x-android/pull/3574/files#diff-9b8993ef173a404ecbf23a0c01d42502c4e95379978611aa95c3e9fc7785b0a5R53-R54) is still correct to me, and the application needs a non-nullable filename. So...
OK, let's wait for the SDK to change, I think this is discussed in #2570.