Benoit Marty

Results 320 comments of Benoit Marty

@yostyle looks like you have pushed commits on the wrong branch

Closed because we got no sign of life from submitter.

Hello @yostyle thanks for reporting. Will you test the fix in the link you provided? A PR would be welcome if this is fixing the issue. Else please let me...

> One small issue with this implementation is the snackbars don't appear until the view is closed.. not sure why, because I copy-pasted some other code that does the same...

Thanks for the update. I am wondering if the Snackbar interferes too much with the System clipboard alert (but I did not test the code yet):

@frebib thanks for the update. I believe that this PR can be merged, but it needs to be updated first, to fix the conflict. We apologize for the delay on...

Yes, detected during the PR review https://github.com/element-hq/element-x-android/pull/3399#discussion_r1764641667

Hello @frebib , please see my comment on your other PR: https://github.com/element-hq/element-x-android/pull/2892#issuecomment-2670782197 that also applies fro this one. Thanks!