Ben Mabey

Results 48 comments of Ben Mabey

Full backtraces are sent to airbrake.. at least that is the intent and my experience with the library. :) The data from `ex-info` isn't sent and I have #12 open...

I am looking into contributing both Mixup and CutMix augmentations. Both of these augmentations take multiple images in order to do the augmentation. As far as I can tell all...

I think the original reason was due to some initial limitations of webrat. I have pull request #46 that allows for using the absolute URL but I haven't looked at...

Yeah, that sounds reasonable. I'll merge in a PR with optional Nokogiri support.

It looks good though. Thanks for the pull request! I'll merge it in and make a release (probably tomorrow).

I've been hesitating on this patch becuase I'm not sure that I like the option `:path_only`. I like the functionallity provided, but am unsure at how intuitive the API is....

Ah, I didn't know that was the option for `url_for`. That makes more sense now. I do like the suggestion of `relative: true` better though. I suppose another option would...

I think allowing users to be explicit about what mailer to use makes sense and I like your proposed method `EmailSpec.use_mailer_lib = :action_mailer`. I think if `EmailSpec.use_mailer_lib` is `nil` we...

This is a feature that instantly gives you a green test suite. :) Seriously though, I have no idea why requiring email-spec would do this since there is no minitest...

I can't recall why email-spec relies on rspec-rails. It may not be necessary and could be removed. I'd be willing to merge in a patch that does that but I...