Ben Mabey

Results 48 comments of Ben Mabey

After looking at the file again I'm somewhat confused why the `should` is in there in the first place because a [few lines down](https://github.com/bmabey/email-spec/blob/master/lib/email_spec/helpers.rb#L114) an exception is thrown if there...

I haven't done rails dev for a bit.. and I can't say that I've heard of mail interceptors. That said, the mathchers are intended to be used to help test...

No.. I guess it wasn't intentional per say.. I didn't really think much about it at the moment. :) If we remove the 0 but then release a `1.1.1` will...

Why do you need to do a URI::parse(url)? Could it not just use the URL? I understand your reasoning behind this. However, I wonder if other people would expect/want the...

I like the idea of making it an option and having the default option be relative since I bet the majority of users operate in that context. This would mean...

@cpsievert I've removed the `console` calls and fixed the regression for #33. The fixes have been squashed to the same commit. It should be ready to merge in now.

@kshirley Thanks for investigating the problem. WRT short term solutions my vote would be for the first one proposed for the same reasons you don't like the second option. Another...

Looks like it is pretty straight forward to fix.. a number of selects are selecting the top element with a certain class or all of them without taking into account...

We ended up fixing this in our own version. Multiple visualizations are now possible on a single page however we punted on allowing multiple viz state from going into the...