Bjorn Lu

Results 767 comments of Bjorn Lu

We'll cut a patch release soon, I think within the next couple days. I'd like to merge some other PRs first and cut a patch, then start the next minor.

I think this is working as expected too. The documentation already clarifies this: > Define global constant replacements. Entries will be defined as globals during dev and statically replaced during...

They exist. `-swc` packages are special templates derived from the React templates with the Vite plugin swapped to `@vitejs/plugin-react-swc`. You can pass them to `--template`.

Thanks for the PR, however we had already received another PR for this: https://github.com/vitejs/vite/pull/16321

It's updated now, I just published the latest site deployment.

Similar https://github.com/vitejs/vite/issues/8739. Currently Vite reconstructs the links, hence the original attributes are not preserved. Vite does have partial support for preserving some attributes, but it has its own issues too:...

I think this requires a fair bit of refactor to fix and likely some re-architecture to link handling, so probably not a good first issue for a newcomer 😅

Is the issue with `.gzip` or `.gz`? If it's the latter, there's an upstream issue for that https://github.com/lukeed/sirv/issues/158. I'm not sure Vite is affecting it otherwise. It would be nice...

I don't think so based on https://github.com/lukeed/sirv/blob/50b1964b8a8342e14a711d47f793298c2a7aeeb7/packages/sirv/index.js#L95 (also tested locally)

Not opposing this addition as I'd like to support preview releases too, but is there a reason for a GitHub app for this? Couldn't it fit entirely in CI with...