Bjorn Lu

IIUC the GitHub app would be the way to authenticate and start using pkg.pr.new, and no other sign in is required? I can get by a GitHub app in that...

Why can't multiple dev servers share the same cache? Shouldn't it not be dependant on the values of the config?

I see. Though there is still the tradeoff that if the subtrees overlap, we would have duplicated the cache in memory. Personally I think since editing the `tsconfig.json` isn't common,...

Do you mean that the current `server` top-level variable is only causing one server to restart only? I agree that it would be good to handle multiple servers there, but...

I think it's ok since editing the `tsconfig.json` is not common, and the memory taken by the cache is something people will likely hit more often? If we can solve...

I'm not sure if this is correct. `require()` if building for browsers should use the browser entry if so. Bundlers can also handle if require resolves to an ESM file....

I'm curious how this happens in the first place. According to https://github.com/vitejs/vite/blob/c373251123ffbfddf2f703b6a62a5d9b1a03db67/packages/vite/src/node/ssr/fetchModule.ts#L39-L48 Only `main` field should be used when resolving bare imports. If it's not a bare import (e.g. it's...

Is this PR still needed?

Isn't this about config bundling, so the optimizer shouldn't be in play here? The test fail is not too terrible I think and I'm ok with fixing the test. This...

@garydex I've replied in the other PR --- About the ecosystem-ci results, seems like it does break a few downstream frameworks, and perhaps we should move this to the next...